-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Javascript in status.html to separate file #131
Conversation
Hey Jake. You can click on detail to check the build log for travis for your particular PR. Check it out here: https://travis-ci.org/manu-chroma/username-availability-checker/builds/449037018?utm_source=github_status&utm_medium=notification for the current failing build. Also, try testing your changes locally. That might help you in knowing what might have gone wrong (apart from the logs) |
OK, I believe it was just that I left some trailing whitespace (though the log is fairly verbose so I might have missed something else further down). |
I kind of agree. The log went just too verbose on failure. Some of the initial stuff was not very useful as such. Maybe we can do something about that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Great, thank you for your help! |
I will let someone else have a look too, before I merge this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small issue: there are template tags (which would normally be rendered by flask) in the Javscript which do not get rendered when they are moved to a separate file. This causes the entire site to break. Not @jakethakur 's fault. Looking into this more. Other than that, it looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
OK, that should have fixed it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! :D
We have to consider something like this: https://stackoverflow.com/questions/37259740/passing-variables-from-flask-to-javascript/37260465 or maybe a better solution for js file to have that config. |
I've got a solution that's similiar to @manu-chroma 's suggestion. Can submit PR if you'd like. My thoughts are that it should be addressed in a different issue/pr, as it is a bit out of the scope of this task. |
JS based rendering interferes with our own custom icons which have similar name to font awesome classes resulting in replacement with a not found svg.
how to answer this question? im new |
Moves the javascript in status.html to a new status.js file.
Closes #123